camaraproject / QualityOnDemand

Repository to describe, develop, document and test the QualityOnDemand API family
https://wiki.camaraproject.org/x/zwOeAQ
Apache License 2.0
38 stars 60 forks source link

Rename properties to new terms #129

Closed jlurien closed 1 year ago

jlurien commented 1 year ago
hdamker commented 1 year ago

We should wait with this PR until https://github.com/camaraproject/WorkingGroups/issues/157 is finally decided with a vote as requested by Telefonica.

hdamker commented 1 year ago

Guess we are ready to due these changes now as the guidelines are also updated.

@eric-murray @jlurien @patrice-conil @sfnuser @akoshunyadi would you have a look and approve as well?

hdamker commented 1 year ago

@jlurien will you resolve the comments or should I?

hdamker commented 1 year ago

AS @jlurien seems not be available I have addressed the comments above. @akoshunyadi and @sfnuser can you shortly check and approve?

sfnuser commented 1 year ago

AS @jlurien seems not be available I have addressed the comments above. @akoshunyadi and @sfnuser can you shortly check and approve?

@hdamker - Cheers. Are we planning to update the commit in two other places (line 83 & 95) as well?

hdamker commented 1 year ago

@sfnuser :

Are we planning to update the commit in two other places (line 83 & 95) as well?

Thanks for the hint ... have done further updates of error examples in lines 71, 77, 83, 89, 95 to get all the error examples consistent with the new property terms. Please have a view.

sfnuser commented 1 year ago

@sfnuser :

Are we planning to update the commit in two other places (line 83 & 95) as well?

Thanks for the hint ... have done further updates of error examples in lines 71, 77, 83, 89, 95 to get all the error examples consistent with the new property terms. Please have a view.

Thanks. Looks good to me.