search

camaraproject / QualityOnDemand

Repository to describe, develop, document and test the QualityOnDemand API family
https://wiki.camaraproject.org/x/zwOeAQ
Apache License 2.0
38 stars 60 forks source link

Pull Request for Initial QoD Cucumber Test contribution. #134

Closed mdomale closed 1 year ago

mdomale commented 1 year ago

Pull Request for Initial QoD Cucumber Test contribution. Fixes https://github.com/camaraproject/QualityOnDemand/issues/133

mdomale commented 1 year ago

As agreed in the issue https://github.com/camaraproject/WorkingGroups/issues/61 this is the proposal using the toolstack Maven,Junit 5,Java,wiremock .It is not depending on the implementation, that's why it is committed here and not in the PI.

patrice-conil commented 1 year ago

Hi @mdomale, Thanks for your proposal, it's a nice work. Many cucumber gurus argue for a single 'when' clause by test ... but in case of API test I'm not sure that will clarify test cases. Regarding wiremock, I prefer to register real replies from mocked backend than to generate partial ones using stubFor. I think it's a better way to verify that all mappings are correct, and sometimes to delegate mocking to backend providers themselves :)

mdomale commented 1 year ago

@patrice-conil Intention for this proposal is having basic tests for QoD using cucumber framework. These test cases can be executed locally without any need of dependencies except QoD service up and running on local. As these are basic tests and easily adaptable by everyone for getting basic confidence around QoD service workability , on side note these can be extended further as well. Full qualification tests are not intended as a part of this contribution . By using cucumber framework we have flexibility to switch to any required backend . cc @akoshunyadi

hdamker commented 1 year ago

Thanks for the reviews @akoshunyadi @patrice-conil @shilpa-padgaonkar