search

camaraproject / QualityOnDemand

Repository to describe, develop, document and test the QualityOnDemand API family
https://wiki.camaraproject.org/x/zwOeAQ
Apache License 2.0
37 stars 60 forks source link

Align event notification with CloudEvents spec #224

Closed jlurien closed 7 months ago

jlurien commented 9 months ago

What type of PR is this?

What this PR does / why we need it:

Align QoD event notification with recently approved guidelines adhering to CloudEvents specification

Which issue(s) this PR fixes:

Fixes #221

Changelog input

- Notification event changed to comply with CloudEvents specification
hdamker commented 8 months ago

The last commit is about a month ago here. Does it mean that we are ready here? ... Guess that we need your reviews @jlurien @eric-murray @RandyLevensalor @akoshunyadi

jlurien commented 8 months ago

The last commit is about a month ago here. Does it mean that we are ready here? ... Guess that we need your reviews @jlurien @eric-murray @RandyLevensalor @akoshunyadi

PR is mine so I cannot review it myself, but yes, we need this to be reviewed, it is an important change. I would add @bigludo7 as reviewer here as he is in charge of this same tasks in other subprojects.

hdamker commented 7 months ago

@bigludo7 @eric-murray @akoshunyadi @RandyLevensalor @akoshunyadi : there are no new comments since last week. Are we good to go to merge today?

jlurien commented 7 months ago

@hdamker I think this is ready to be merged. Thanks for all comments and feedback