feat: add the `statusInfo` as parameter to the `SessionInfo`

camaraproject / QualityOnDemand

Repository to describe, develop, document and test the QualityOnDemand API family

https://wiki.camaraproject.org/x/zwOeAQ

Apache License 2.0

37 stars 60 forks source link

feat: add the `statusInfo` as parameter to the `SessionInfo` #273

Closed maxl2287 closed 2 months ago

maxl2287 commented 3 months ago

What type of PR is this?

Add one of the following kinds:

bug
correction

What this PR does / why we need it:

Adds the statusInfo as parameter to the SessionInfo

Which issue(s) this PR fixes:

Fixes #267

linux-foundation-easycla[bot] commented 3 months ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: maxl2287 / name: Maximilian Laue (07440c2cfe831755d6ff90d9021907374f994522, a71614670bbe4342a60c2cd57fd8ce2aea8e3f88, 23e29a653ce254202daf9b8dd3c5955804d5fe71, ac48699c3c994fa7545c5be710bece1fb3c9a328, 92e4e262c0ec4d67417c1e94f8cccc19b363c86f, cc717c8d81e0cb87881ddaddd26e4f4e8ab719b1, f826778a86a9b737e22110b0fa5d49b403b7c974, 6b581567be1234e38eb7bfd35e8f95f648b126de, 4baefa8a4c2ae0f2225fe8030c23bc88ff64e068, 6d98c13d9d2462f9b5f24713158157583ca5f4ab, 8c6a4d3f5af9cb521442d56ca8cc84b34b7cb460, f0159b6ee3be696a87e8176173b6fabe6369f27d)
:white_check_mark: login: hdamker / name: Herbert Damker (0ded8a448d15b0406eb7967c22498a50daf5a1ca)

hdamker commented 3 months ago

LGTM - but should be merged only after the patch release 0.10.1 is done (and then the documentation need to be changed accordingly again).

hdamker commented 2 months ago

@maxl2287 would you resolve the merge conflicts? PR #277 changed the SessionInfo structure and the version should be now only "wip" (see my commit).

maxl2287 commented 2 months ago

@hdamker, yes I will continue on that next Monday.

maxl2287 commented 2 months ago

@hdamker PR is updated to version 0.11.0-wip and conflicts were resolved.

Please take a look.

hdamker commented 2 months ago

You have to remove "(the statusInfo parameter is not included in the current version but will be adding to SessionInfo in an upcoming release)" from line 107

Good catch, reversing the documentation fix for 0.10.1. More precise: the sentence in line 106/107 need to reverse the PR #267, so changing the lines 106/107 back to:

This behavior allows clients which are not receiving notification events but are polling to get the session information with 
the `qosStatus` `UNAVAILABLE` and `statusInfo` `NETWORK_TERMINATED`. Before a client can attempt to create a new QoD session