Closed hdamker closed 1 week ago
Initial review comments left: CHANGELOG.md need to be for full new API, API Readiness Checklist and .feature files need to updated as well.
I should have addressed all the issues with an update on the current PR: https://github.com/camaraproject/CallForwardingSignal/pull/95
issues: https://github.com/camaraproject/CallForwardingSignal/issues/96 https://github.com/camaraproject/CallForwardingSignal/issues/97 https://github.com/camaraproject/CallForwardingSignal/issues/98
M4 review:
changelog.md: need to update links with renamed API yaml file. readme.md: same update needed as above few editorial comments
release tracker to be updated to 0.2.0 (from 0.2.0-rc.2)
with these updates done, release r1.3 can be created: LGTM from release mgmt.
@tanjadegroot
comment addressed with: https://github.com/camaraproject/CallForwardingSignal/pull/101
About the release tracker: https://wiki.camaraproject.org/display/CAM/call-forwarding-signal+v0.2.0
it already refers to rel v0.2.0 (maybe I did it too early :-) )
Public Release tag created (https://github.com/camaraproject/CallForwardingSignal/releases/tag/r1.3) and release tracker updated.
Public Release tag created (https://github.com/camaraproject/CallForwardingSignal/releases/tag/r1.3) and release tracker updated.
@FabrizioMoggio you are quite fast, @tanjadegroot had not even a chance to approve the release PR 😉
Edit: just learned that there was a "pre-approval" to create the release within https://github.com/camaraproject/ReleaseManagement/issues/77#issuecomment-2329710245. So all fine. Just that an explicit approval would be preferable.
Hereby explicit RM approval of the PR (after the fact). All OK and this issue can be closed.
Release PR or issue to review
https://github.com/camaraproject/CallForwardingSignal/pull/95https://github.com/camaraproject/CallForwardingSignal/pull/101 Review actionsAssign this issue to yourself and follow the below list. For any review action, review the file(s) in the issue/PR listed above. Put comments in the above issue or PR if they concern non-changed files/text. Put a short summary of the main review result here into the review issue.
Release actions
Assign this issue to yourself or another RM team member and follow the below list. When done, tick the box in this issue.
Additional comments