cambiatus / backend

Cambiatus GraphQL API
GNU Affero General Public License v3.0
20 stars 18 forks source link

Feature/categories filter for shop products #246

Closed MatheusBuss closed 2 years ago

MatheusBuss commented 2 years ago

What issue does this PR close

Closes #242

Changes Proposed ( a list of new changes introduced by this PR)

How to test ( a list of instructions on how to test this PR)

Run mix test test/cambiatus_web/schema/resolvers/shop_test.exs

MatheusBuss commented 2 years ago

This implementation is failing because the join results in duplicate entries when a product is in two categories being queried at the same time. This is still to be fixed.

henriquecbuss commented 2 years ago

@MatheusBuss since this depends on #237 , it might be a good idea to change the target branch to be feature/shop-categories. If you don't, and you finish this before #237, you will end up pushing all of the code of that PR to master before it's done. It will also make this PR a lot easier to review, since it will only show the differences between this PR and #237

(At least I think so, maybe @lucca65 can correct me if I'm wrong 😅)

To do it, click "Edit" on the top of the page, and change the dropdown that says "base:master" to the correct branch

Untitled

lucca65 commented 2 years ago

@NeoVier acho que podemos mirar a master aqui, mas com a disciplina de não mergear/aprovar até o outro PR, acho que assim fica melhor do que ter um PR grandão.