cambiatus / backend

Cambiatus GraphQL API
GNU Affero General Public License v3.0
20 stars 18 forks source link

Enhancement/update email info #286

Closed MatheusBuss closed 2 years ago

MatheusBuss commented 2 years ago

What issue does this PR close

Closes #284

Changes Proposed ( a list of new changes introduced by this PR)

How to test ( a list of instructions on how to test this PR)

Locally with a transfer email

  1. Get a valid transfer id that is on the dev db
  2. Run iex -S mix phx.server
  3. Get a transfer from the db by running {:ok, t} = Cambiatus.Commune.get_transfer(#{transfer_id})
  4. Send an email for the transfer by running CambiatusWeb.Email.transfer(t)
  5. Go to localhost:4000/dev/mailbox
  6. Get the token to unsubscribe from the unsubscribe link at the end of the email
  7. Go to http://localhost:4000/api/unsubscribe?token=#{token}
  8. Check the unsubscribe page
lucca65 commented 2 years ago

bro, can you convert it to a draft so its easier for us to know its not done yet?

MatheusBuss commented 2 years ago

Should be ready now. Since I'm not on my home machine I don't have access to my ssh to staging. So I still have to test it there. I'll convert it to draft untill then.

MatheusBuss commented 2 years ago

@juramos-2020, @lucca65 this is what staging is sending

Transfer: image

Monthly digest: image

Claim: image

lucca65 commented 2 years ago

Pessoal, o botão tá com padrões diferentes, um tá em negrito e os outros não. Talvez vale a pena colocar estilos no css para ajudar na consistência?

MatheusBuss commented 2 years ago

@lucca65 idealmente poderíamos refatorar esses emails com alguns componentes padrões, como o footer e os botões, além de ajudar com a legibilidade do código. Mas como temos a release daqui a pouco quem sabe podemos deixar pra um futuro redesign dos emails. O que acha?

Os botões devem estar padronizados. Se quiser testar pelo staging já fiz o deploy.