cambiegroup / flowchem

Flowchem is an application to simplify the control of instruments and devices commonly found in chemistry labs.

MIT License

15 stars 5 forks source link

R2 overwrites parent method #115

Open JB-Wolf opened 10 months ago

JB-Wolf commented 10 months ago

R2 Overwrites Valve method

Problem

set_position and get_position are redefined

Effect

Maintainability harder
affects behaviour uniformity
Solution

Device should just expose rule in _change_position (only device_component specific code part). Device level method is selected via hw_device attribute.