JB-Wolf
commented
1 week ago So I think the way to go is: Crate alength component, from this ALL (x, y and z) can inherit. The length component shoyld have: current position, go to position, and available positions. Also it shoyld have an attribute which is: discrete or continuous. For case like AS where you have a tray, one can read the tray enum, from that buildt positions available, eg the y component could be then waste wash, left tray, right tray and if left and right further devided into a,b,c,d,e,f. So tale either tuple or dict as input. Z component in this case up and down And y component 123456 Look up how to deal with special positipns like needle exchange. In continuous case, options would be a range in length units, with optional resolution/step size Implementation of vial objects needs to be done outside of flowchem, on orchestrator level
Von: Miguel Garcia @.***> Gesendet: Montag, 21. Oktober 2024 11:36:50 An: cambiegroup/flowchem Cc: Jakob Wolf; Comment Betreff: Re: [cambiegroup/flowchem] Autosampler integration. (PR #148)
@magz97 commented on this pull request.
In src/flowchem/devices/knauer/knauer_autosampler.pyhttps://github.com/cambiegroup/flowchem/pull/148#discussion_r1808429118:
-
basically, only acts a s container internally and to make substance access easy
-
-# TODO create a Tray class -class Tray:
Or you would change the xyz component and add these two classes? Or maybe a new child component "Autosampler" that uses Vial() and Tray(). (Because a 3D printer wouldn't need these classes for example)
— Reply to this email directly, view it on GitHubhttps://github.com/cambiegroup/flowchem/pull/148#discussion_r1808429118, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AR7MYL4EKPSDOY7CSBCWLSLZ4TDLFAVCNFSM6AAAAABOX3N5GOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGOBRGQ3TKNBRGI. You are receiving this because you commented.Message ID: @.***>
Created a patch branch from the common ancestor of main_all_merged and AS_integration (commit: https://github.com/cambiegroup/flowchem/commit/085f9668a2b3bdea733d9d8dc8ac3d3190266b27).
Cherry-picked commits related to Autosampler.py from AS_integration. Merged the patch branch back into AS_integration for history tracking and into a new branch, autosampler_integration (branched from main_all_merged).
Applied the necessary changes to the autosampler_integration branch to ensure compatibility with the latest FlowChem version, specifically for the Knauer AutoSampler.