Better types for accumulators & proofs

cambrian / accumulator

Cryptographic accumulators in Rust.

https://cambrian.github.io/accumulator

MIT License

133 stars 34 forks source link

Better types for accumulators & proofs #1

Closed eddiew closed 5 years ago

eddiew commented 5 years ago

We should provide newtypes/structs for accumulators and their proofs so we're not working with raw group elements/exponents.

whaatt commented 5 years ago

Yep, this will be useful when we start implementing VCs.

I'm thinking:

A newtype around group elements representing accumulators/witnesses
A newtype around BigUints representing prime-valued elements (or their aggregations)

whaatt commented 5 years ago

At the same time, this might be better suited to a higher layer of abstraction (where we have a clearer picture what the prover and verifier are doing in a real-world sense). The interface as it exists now is pretty faithful to the math.

eddiew commented 5 years ago

I added a NonMembershipProof type but happy to punt on the rest until it's clearer how we will use the accumulator fns.

eddiew commented 5 years ago

Added struct Accumulator type. We should do the same for vector commitments now

whaatt commented 5 years ago

done. gonna close this issue for now, and in the process of building our PoC we might uncover useful changes to the acc and vc interfaces