Support additional statements

cambridge-alpha-team / unvisual-frontend

This is the frontend part for the unvisual project

1 stars 0 forks source link

Support additional statements #50

Open isaac-dunn opened 9 years ago

isaac-dunn commented 9 years ago

We actually don't have that long left, so if we want to add new nodes such as play_chord then we should do it sooner rather than later.

tjvr commented 9 years ago

Yes, we should talk about what instructions we want to add.

I guess the question is really, what kind of programming—elements of "computational thinking"—do we want to include?

tjvr commented 9 years ago

It might be worth mentioning that the current class hierarchy, which has one "class" for every type of statement, will make this tedious. We could use abstraction to make adding new statements easier.

LauraneS commented 9 years ago

I branched on adding-chords-#50, and wrote a ChordNode class, which I think works but I can't connect to SonicPi from unvisual, so I can't check if it actually plays correct music. From the POV of the UI, it seems to be displayed properly though

RusticFlare commented 9 years ago

I've had a look at that branch(adding-chords-#50) and it looks pretty good. A couple of syntax points:

In the Sonic Pi page for chord there is no space between chord and the (.
It may be better to define how the children are displayed in the ChordNode class rather than having a loop that goes over them and having a specific display method in the ChoiceNode class for "chord type". This would also stop the comer and blank space being boxed.