cambridge-alpha-team / unvisual-frontend

This is the frontend part for the unvisual project
1 stars 0 forks source link

You cannot delete Synths or Samples #71

Closed RusticFlare closed 9 years ago

LauraneS commented 9 years ago

Am happy with "lets you delete sample and synth" part, but if I cannot delete an empty fx; in my particular example, it is inside a loop, and there is nothing else in that loop. If there is another statement in the loop it lets me delete it though. Actually, we can never delete a node from a loop if it is the only one in that loop. Is that something we decided? or a bug?

RusticFlare commented 9 years ago

That was decided, an empty loop may as well not exist.

tjvr commented 9 years ago

Actually, we can never delete a node from a loop if it is the only one in that loop.

@RusticFlare: it still makes sense to delete the last thing in a loop, since you might want to delete it and replace it with something else.

LauraneS commented 9 years ago

That is my opinion as well.

Sorry if this was already discussed … On 25 Feb 2015, at 19:15, Tim notifications@github.com wrote:

Actually, we can never delete a node from a loop if it is the only one in that loop.

@RusticFlare: it still makes sense to delete the last thing in a loop, since you might want to delete it and replace it with something else.

— Reply to this email directly or view it on GitHub.

RusticFlare commented 9 years ago

This would require 3 different adding code modes to fix, one for below current position, one for above, one for inside.

RusticFlare commented 9 years ago

A fix for loops is now issue #76