cambridge-alpha-team / unvisual-frontend

This is the frontend part for the unvisual project
1 stars 0 forks source link

Empty loops; can add to start of a loop #83

Closed Psyclone150 closed 9 years ago

Psyclone150 commented 9 years ago

Fixes #76. You can now delete all child nodes of a loop and have the option of adding a new node to the start of a loop as an alternative to adding nodes after the loop, if a loop is currently selected.

RusticFlare commented 9 years ago

Don't allow the user to add a loop in a loop.

RusticFlare commented 9 years ago

If I add something at the start of a loop then I start adding code as children for everything (instead of after them). This bug needs fixing. Also can you please try and fix the merge conflicts. Thanks

RusticFlare commented 9 years ago

This seems good to me, I'm going to have a look at the merge conflicts.

RusticFlare commented 9 years ago

I've fixed the conflicts (YIPPEE!!!), but have also found another bug (YIPPEE!!!). If you try to add an fx as the first piece of code in a loop then it is wrongly added around the root's children.

RusticFlare commented 9 years ago

If the first thing you do is add code first in a loop it adds the wrong code

After adding code from inside a loop then this does't happen

Psyclone150 commented 9 years ago

I think I've fixed those two bugs now. Does it seem alright?

RusticFlare commented 9 years ago

Sorry, I've found another bug. If you navigate inside a loop and add anything; then make the tempo your activeNode; then try to add code, you add the wrong code:

Psyclone150 commented 9 years ago

How about now?

LauraneS commented 9 years ago

Think it works!

Psyclone150 commented 9 years ago

Great! Shall I merge it now?

RusticFlare commented 9 years ago

I'm just going to test it now.

RusticFlare commented 9 years ago

I now can't delete everything inside a loop.

RusticFlare commented 9 years ago

I just merged Isaac's code so I'm going to fix those conflicts.

Psyclone150 commented 9 years ago

Thanks for getting this all sorted for me! Sorry I wasn't around to help out at the end.