Closed Psyclone150 closed 9 years ago
Don't allow the user to add a loop in a loop.
If I add something at the start of a loop then I start adding code as children for everything (instead of after them). This bug needs fixing. Also can you please try and fix the merge conflicts. Thanks
This seems good to me, I'm going to have a look at the merge conflicts.
I've fixed the conflicts (YIPPEE!!!), but have also found another bug (YIPPEE!!!). If you try to add an fx
as the first piece of code in a loop
then it is wrongly added around the root
's children.
If the first thing you do is add code first in a loop it adds the wrong code
play
adds a loop
sleep
adds a play
fx
adds a sleep
After adding code from inside a loop
then this does't happen
I think I've fixed those two bugs now. Does it seem alright?
Sorry, I've found another bug. If you navigate inside a loop
and add anything; then make the tempo
your activeNode
; then try to add code, you add the wrong code:
loop
adds a play
play
adds a sleep
sleep
adds a fx
How about now?
Think it works!
Great! Shall I merge it now?
I'm just going to test it now.
I now can't delete everything inside a loop
.
I just merged Isaac's code so I'm going to fix those conflicts.
Thanks for getting this all sorted for me! Sorry I wasn't around to help out at the end.
Fixes #76. You can now delete all child nodes of a loop and have the option of adding a new node to the start of a loop as an alternative to adding nodes after the loop, if a loop is currently selected.