Dev-ship-demo - Githubissues

cambridge-cares / TheWorldAvatar

A knowledge-graph-based digital twin of the world.

https://theworldavatar.io/

MIT License

84 stars 25 forks source link

Dev-ship-demo #1205

Closed ChungTingLao closed 3 months ago

ChungTingLao commented 3 months ago

added URL to allow users to download dispersion simulation output files
added capability to load ship data from CSV files using stack data uploader
caught invalid simulation input conditions (no ships within scope, no wind)

ChungTingLao commented 3 months ago

Do we still need the changes in the stack-clients?

I have reverted the changes in the stack-clients since they are no longer needed.

kok-foong commented 3 months ago

Do we still need the changes in the stack-clients?

I have reverted the changes in the stack-clients since they are no longer needed.

Make sure all the commits related are reverted, there should not be any diffs in the 'Files changed' tab

kok-foong commented 3 months ago

Speaking of README, it'll be good if you can state the requirements to load ship data from RDB, e.g. the table name and the column names required, to reuse the ship input agent

ChungTingLao commented 3 months ago

Do we still need the changes in the stack-clients?

I have reverted the changes in the stack-clients since they are no longer needed.

Make sure all the commits related are reverted, there should not be any diffs in the 'Files changed' tab

This is now done in the latest push.

Speaking of README, it'll be good if you can state the requirements to load ship data from RDB, e.g. the table name and the column names required, to reuse the ship input agent

The README has been updated to address this comment.