fixing poller seg_faults and deadlock, by KiSuh

[jankcorn]

What problem are you trying to solve with this patch?

On Wed, Dec 9, 2015 at 11:40 AM, Han Wang notifications@github.com wrote:

---

You can view, comment on, or merge this pull request online at:

https://github.com/cambridgehackers/connectal/pull/103 Commit Summary

• fixing poller seg_faults and deadlock, by KiSuh

File Changes

• M cpp/poller.cpp https://github.com/cambridgehackers/connectal/pull/103/files#diff-0 (23)
• M cpp/portal.h https://github.com/cambridgehackers/connectal/pull/103/files#diff-1 (1)

Patch Links:

• https://github.com/cambridgehackers/connectal/pull/103.patch
• https://github.com/cambridgehackers/connectal/pull/103.diff

— Reply to this email directly or view it on GitHub https://github.com/cambridgehackers/connectal/pull/103.

[hanw]

@kslee

[jameyhicks]

Thanks for contributing a fix.

However, I think we can do something simpler by preallocating the fds array to a configurable size. For example, we only support 16 hardware portals, so we could just preallocate it to that size. Plus 1, for the pipe that is used to wake up poll. I tested this style with DMAC but I guess I wasn't confident enough to push it to connectal.