cambridgehackers / connectal

Connectal is a framework for software-driven hardware development.
MIT License
161 stars 46 forks source link

Is it possible to support the opensource bsc? #169

Closed kurocatus closed 4 years ago

kurocatus commented 4 years ago

I am trying to use the opensourced version of bluespec compiler together with connectal. However, in order to successfully build the project (generating bluesim executables), I have to make some changes to connectal (connectal.txt).

Building errors are due to directory organization and internal API difference between closesource and opensourced version bsc. So I would like to know if there is any plan for connectal to support the opensourced version, since it seems to be the most accessible one for most people and hopefully Bluespec Inc. will continually maintain the repo.

jameyhicks commented 4 years ago

I've been using the opensource bluespec compiler with Connectal for a few months now. However, I have only tested verilator simulation.

Thank you for providing the change to make bluesim work with the opensource version. Would you like to make a pull request?

kurocatus commented 4 years ago

Applying the patch without further modifications would actually make connectal break if someone is using an older bluespec compiler (versions in README.md), so I don't know if it is a good idea to make a pull request right away.

It would be better to get the bsc version and depending on that, choose different codes to compile. But how should I get the compiler version reliably? bsc -help doesn't give any useful information.

jameyhicks commented 4 years ago

I don't know if I have any users that depend on closed source bsc so I don't know how much work should be put into supporting it.

Also, the open source bsc doesn't have version numbers yet.

On Fri, Jun 5, 2020 at 10:49 PM kurocatus notifications@github.com wrote:

Applying the patch without further modifications would actually make connectal break if someone is using an older bluespec compiler (versions in README.md), so I don't know if it is a good idea to make a pull request right away.

It would be better to get the bsc version and choose different codes depending on that. But how should I get bsc version reliably? bsc -help doesn't give any useful information.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/cambridgehackers/connectal/issues/169#issuecomment-639963650, or unsubscribe https://github.com/notifications/unsubscribe-auth/AASTPMYTEYOQOGTYMW7ES4DRVGVCTANCNFSM4NTHTLCA .

jankcorn commented 4 years ago

I also think that there is not much value in continuing support for the closed source bsc. Despite this, I think there is definitely a long term need for the open source bsc to have compiler version numbers.

I created a pull request for cambridgehackers/bsc to give an idea of the changes required. I am not sure the best way to actually manage/update the environment variable "COMPILERVERSION" (I have just dropped the definition into src/comp/Makefile temporarily to show how it could work)

BTW, if we have a compiler version string, then putting in conditional compilation for the bluesim changes should be trivial.

Ideas? jca

On 6/7/20, Jamey Hicks notifications@github.com wrote:

I don't know if I have any users that depend on closed source bsc so I

don't know how much work should be put into supporting it.

Also, the open source bsc doesn't have version numbers yet.

On Fri, Jun 5, 2020 at 10:49 PM kurocatus notifications@github.com wrote:

Applying the patch without further modifications would actually make

connectal break if someone is using an older bluespec compiler (versions in

README.md), so I don't know if it is a good idea to make a pull request

right away.

It would be better to get the bsc version and choose different codes

depending on that. But how should I get bsc version reliably? bsc -help

doesn't give any useful information.

You are receiving this because you commented.

Reply to this email directly, view it on GitHub

https://github.com/cambridgehackers/connectal/issues/169#issuecomment-639963650,

or unsubscribe

https://github.com/notifications/unsubscribe-auth/AASTPMYTEYOQOGTYMW7ES4DRVGVCTANCNFSM4NTHTLCA

.

--

You are receiving this because you are subscribed to this thread.

Reply to this email directly or view it on GitHub:

https://github.com/cambridgehackers/connectal/issues/169#issuecomment-640295467

kurocatus commented 4 years ago

A tentative pull request #170