search

cambridgehackers / connectal

Connectal is a framework for software-driven hardware development.
MIT License
159 stars 46 forks source link

fix buffer size #193

Closed GTwhy closed 1 year ago

GTwhy commented 1 year ago

Change fname buffer size from 128 to 512 to avoid reading 512 bytes from a region of size 128.

jameyhicks-cmt commented 1 year ago

This change seems safe enough, but how would formatting two integers ever cause the string to be that large?

GTwhy commented 1 year ago

This change seems safe enough, but how would formatting two integers ever cause the string to be that large?

You're right, I didn't pay attention to the details of fname.

GTwhy commented 1 year ago

Close this PR and add this commit in #195