cambridgehackers / connectal

Connectal is a framework for software-driven hardware development.
MIT License
161 stars 46 forks source link

obsolete bsc version checking bug in `scripts/Makefile.connectal.build` #197

Closed 01xz closed 1 year ago

01xz commented 1 year ago

hi,

i'm now using the latest open-source Bluespec Compiler, bsc -v returns

Bluespec Compiler, version 2023.07 (build 0eb551d)
This is free software; for source code and copying conditions, see
https://github.com/B-Lang-org/bsc

Invoking command line:
bsc -v

however, the condition in L76-L78 in scripts/Makefile.connectal.build will be met, and will think of bsc version 2023.07 as obsolete, due to

BSCVERSION in L72 is 2023.07 BSCMAJOR in L73 is 2023

and $(shell test $(BSCMAJOR) -le 2019 &>/dev/null && echo obsolete) will return empty and the ifeq will be met in L76

i think it's a bug here, caused by #192

jameyhicks commented 1 year ago

Good catch!

jameyhicks commented 1 year ago

Fixed