cambridgeuniversity / mod_ucam_webauth

Ucam WebAuth Apache authentication agent (mod_ucam_webauth)
GNU Lesser General Public License v2.1
7 stars 9 forks source link

Stop AAAuthService overwriting logout service URL #26

Open edwinbalani opened 4 years ago

edwinbalani commented 4 years ago

When merging default configuration settings in apply_config_defaults(), the value that should be set by 'AALogoutService' (specifying a URL to which the user can be directed to log out of the central authentication service) will be clobbered if a custom 'AAAuthService' has also been specified in configuration. This is due to a typo.

The end result is that the AALogoutService directive is useless (even the default value will be blown away) if AAAuthService is specified.

This bug has probably never been discovered to date, because (almost) nobody uses a service that isn't production Raven, whose auth service and logout URLs are hard-coded as defaults.