search

camcamfresh / Xiaomi-M365-BLE-Controller-Replacement

Replacing the BLE Controller with a Cellular Controller
143 stars 34 forks source link

Throttle stops working for a second randomly while driving #36

Open pengiundev opened 5 years ago

pengiundev commented 5 years ago

Hey, have you encountered the throttle suddenly stopping to work while driving? It stops working for a second randomly and I'm not sure why that happens.

I think that it may be related to particle electron disconnecting and then reconnecting but from looking at the source code, the throttle should work regardless of being connected to the internet or not?

pengiundev commented 5 years ago

It happens in the event of disconnect, shortly before or after the particle reconnects again

Edit: The tail lights starts to blink, also not only the throttle but the brake disengages too, apparently it triggers a motor brake when pressed softly, but when particle disconnects and reconnects the motor brake doesn't work, too.

I think that the problem is somewhere in the send function, either when you change the period in isConnected when not connected messageTimer->changePeriod(1000); or because in the transmit function you don't transmit anything when the scooter isn't connected and the override flag isn't set.

pengiundev commented 5 years ago

OK, I found where the issue is, I'm still testing but it's working for now. Is it OK to do a PR with the fix?

camcamfresh commented 5 years ago

Sounds good! I'm going to try and put the old firmware version for future reference. I'm not sure if there is anything for the PR I need to do, so let me know if I do.