Uncaught TypeError: Cannot read property 'split' of undefined

mattcodez commented 8 years ago

Set YouTube URL
Check "Play Animation"
Click "Apply"

Atom Version: 1.6.0 System: Microsoft Windows 7 Enterprise Thrown From: editor-background package, v1.2.17

Stack Trace

At /C:/Users/mmolnar/.atom/packages/editor-background/lib/youtube.coffee:65

TypeError: Cannot read property 'split' of undefined
    at YouTube.getMap (file:///C:/Users/mmolnar/.atom/packages/editor-background/lib/youtube.coffee:53:20)
    at Request._callback (file:///C:/Users/mmolnar/.atom/packages/editor-background/lib/youtube.coffee:99:27)
    at Request.self.callback (C:\Users\mmolnar\.atom\packages\editor-background\node_modules\request\request.js:198:22)
    at emitTwo (events.js:87:13)
    at Request.emit (events.js:172:7)
    at Request.<anonymous> (C:\Users\mmolnar\.atom\packages\editor-background\node_modules\request\request.js:1035:10)
    at emitOne (events.js:82:20)
    at Request.emit (events.js:169:7)
    at IncomingMessage.<anonymous> (C:\Users\mmolnar\.atom\packages\editor-background\node_modules\request\request.js:962:12)
    at emitNone (events.js:72:20)
    at IncomingMessage.emit (events.js:166:7)
    at endReadableNT (_stream_readable.js:893:12)
    at doNTCallback2 (node.js:441:9)
    at process._tickCallback (node.js:355:17)

Commands

  2x -3:25.4.0 tree-view:toggle (atom-text-editor.editor.is-focused)
     -3:21.9.0 command-palette:toggle (ol.tree-view.full-menu.list-tree.has-collapsable-children.focusable-panel)
  2x -3:17 core:move-down (atom-text-editor.editor.mini.is-focused)
     -3:16.1.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -3:16.1.0 settings-view:view-installed-packages (ol.tree-view.full-menu.list-tree.has-collapsable-children.focusable-panel)
     -3:01.1.0 editor-background:toggle (atom-text-editor.editor.is-focused)
     -0:58.4.0 settings-view:check-for-package-updates (atom-workspace.workspace.scrollbars-visible-always.seti-ui-no-icons.theme-apathy-theme.theme-one-dark-ui.editor-background)
     -0:36.8.0 editor-background:toggle (atom-text-editor.editor.is-focused)

Config

{
  "core": {
    "autoHideMenuBar": true,
    "disabledPackages": [
      "autocomplete",
      "terminal-plus"
    ],
    "themes": [
      "one-dark-ui",
      "apathy-theme"
    ]
  },
  "editor-background": {
    "blurRadius": 0,
    "box3d": {},
    "image": {
      "customOverlayColor": true,
      "opacity": 80,
      "overlayColor": {
        "red": 0,
        "green": 0,
        "blue": 0,
        "alpha": 1
      },
      "url": "C:/Users/Public/Pictures/Sample Pictures/Hydrangeas.jpg"
    },
    "other": {},
    "text": {},
    "video": {
      "playAnimation": true,
      "youTubeURL": "https://www.youtube.com/watch?v=6q36pnzcw70"
    }
  }
}

Installed Packages

# User
apathy-theme, v1.10.3
editor-background, v1.2.17
editorconfig, v1.2.4
file-icons, v1.6.18
fonts, v1.2.0
highlight-line, v0.11.1
highlight-selected, v0.11.2
language-ejs, v0.2.0
minimap, v4.21.0
project-manager, v2.7.6
react, v0.14.2
rulerz, v0.4.1
save-session, v0.16.0
Sublime-Style-Column-Selection, v1.5.1
sync-settings, v0.7.2

# Dev
No dev packages

vivi90 commented 4 years ago

Steps to reproduce:

Enter YouTube URL
Check "Video Play Animation"

Restart of Atom reproduces the same issue.

Atom: 1.46.0 x64 Electron: 4.2.12 OS: "Manjaro Linux" Linux Kernel: 5.6.11 Thrown From: editor-background package 1.2.42

Stack Trace

Uncaught TypeError: Cannot read property 'split' of undefined

At /home/vivien/.atom/packages/editor-background/lib/youtube.coffee:53

TypeError: Cannot read property 'split' of undefined
    at YouTube.getMap (/packages/editor-background/lib/youtube.coffee:53:21)
    at Request._callback (/packages/editor-background/lib/youtube.coffee:98:24)
    at Request.self.callback (/usr/lib/atom/node_modules/request/request.js:185:22)
    at Request.emit (events.js:182:13)
    at Request.<anonymous> (/usr/lib/atom/node_modules/request/request.js:1161:10)
    at Request.emit (events.js:182:13)
    at IncomingMessage.<anonymous> (/usr/lib/atom/node_modules/request/request.js:1083:12)
    at Object.onceWrapper (events.js:273:13)
    at IncomingMessage.emit (events.js:187:15)
    at endReadableNT (_stream_readable.js:1092:12)
    at process._tickCallback (internal/process/next_tick.js:63:19)

Commands

Non-Core Packages

atom-browser 1.7.0 
atom-ide-terminal 5.0.1 
atom-ide-ui 0.13.0 
atom-music 0.10.1 
atom-ternjs 0.20.0 
audio 1.5.7 
autocomplete-java 1.2.7 
autocomplete-javascript 0.0.2 
autocomplete-sql 0.5.0 
busy-signal 2.0.1 
editor-background 1.2.42 
file-icons 2.1.41 
highlight-colors 0.9.0 
hyperclick 0.0.0 
ide-cpp 0.1.0 
ide-java 0.9.0 
ide-php 0.7.18 
intentions 1.1.5 
java-generator 2.2.3 
language-assembly 0.7.2 
language-haskell 1.19.4 
language-latex 1.2.0 
language-lsl 2.2.0 
language-vhdl 0.7.2 
latex 0.50.2 
latexer 0.3.0 
linter-javac 1.10.0 
pdf-view 0.72.0 
php-ide-serenata 5.2.0 
plantuml-toolkit 0.2.0 
project-manager 3.3.8 
quick-query 1.1.1 
quick-query-sqlite 0.3.2 
teletype 0.13.4 
tree-view-filter 0.5.5 
videoplayer 1.5.1 
xilinx-unisims 0.1.0 
zip-folder 3.3.0

So video support doesn't work at all for me. :-(

freeman42x commented 4 years ago

I get the same error on NixOS Linux on version 1.2.42, Atom 1.42.0

LakshayK0804 commented 4 years ago

Shows the same error on Windows 10 too, any updates?

vivi90 commented 4 years ago

@LakshayK0804 Sorry, none for now. But i plan to fix it later.

camel-chased / editor-background