getGlobalContext and default values fixes

camelCaseDave / xrm-mock

:books: A fake implementation of the Xrm object model. Written in TypeScript against @types/xrm definitions.

MIT License

79 stars 31 forks source link

Closed skfd closed 4 years ago

skfd commented 4 years ago

Hi! Great library, I just want to fix couple of things...

getGlobalContext -- it was already implemented we needed just to expose it.
userId is default GUID -- changed int value to valid GUID so code that might parse it works correctly.
initialise default user variables -- user context should be present event after initialise withouth arguments.
securityRoles, securityRolePrivileges -- empty lists even by default.

Tested this changes against our work project. What do you think?

camelCaseDave commented 4 years ago

Looks good, thanks for the contribution @skfd !

skfd commented 4 years ago

oh wow, thank you for excepting the PR. Not sure what broke the build though, sorry

camelCaseDave commented 4 years ago

@skfd just some linting errors. I'll fix them now.

camelCaseDave commented 4 years ago

skfd commented 4 years ago

Will you be so kind to release new version with these changes? ^_^

camelCaseDave commented 4 years ago

Will you be so kind to release new version with these changes? ^_^

Sure thing. I've just published v3.4.16 https://www.npmjs.com/package/xrm-mock