search

camelaissani / rollup-plugin-closure-compiler-js

Rollup plugin for optimizing JavaScript with google-closure-compiler-js.
MIT License
31 stars 5 forks source link

Fails when there is ES6 getter in source #3

Open camelaissani opened 8 years ago

camelaissani commented 8 years ago

I noticed that this code fails to be compiled:

export class Route {
    constructor(uriPart) {
        this.uriPart = uriPart;
    }

    get uri() {
        return this.uriPart;
    }
}

export class Router {};

Because of the ES6 get synthax

camelaissani commented 8 years ago

See discussion here: https://github.com/rollup/rollup/issues/961

GGG-KILLER commented 7 years ago

Was able to make this stop happening by commenting lines 8530-8532 on node_modules/rollup/dist/rollup.js, apparently the problem is not with closure compiler but with rollup. I put the full report on the discussion (rollup/rollup#961)

camelaissani commented 7 years ago

Thanks very much for your deep investigation. I hope rollup team will give their feedback too.