search

camelaissani / rollup-plugin-closure-compiler-js

Rollup plugin for optimizing JavaScript with google-closure-compiler-js.
MIT License
31 stars 5 forks source link

peerDependency? #8

Open kylecordes opened 7 years ago

kylecordes commented 7 years ago

A frustration of this plug-in is that it brings in its own dependency of the underlying google-closure-compiler library, currently it is using version 20160916.0.0 instead of the much newer version already in my project. Typically the solution for this is a peer dependency, to use whatever version is already in the project rather than install one zone.

How about switching to a peer dependency?

camelaissani commented 7 years ago

This would have been a good idea if I had released the first version of this rollup plug-in with this peer dependency. Now, switching to a peer dependency will cause installation problem for projects which rely on it.

Therefore, I've opted to keep google closure-compiler-js as a dependency and I've released a new version of the plug-in with the latest version of it.

jdonaldson10 commented 7 years ago

It's probably worth adding badges in the README.md to report on how up-to-date dependencies are to serve as a reminder in case things get out of sync in future. I'll submit a PR for this.

@camelaissani +1 on not breaking the backwards compatibility as this would require a major version bump. However, what's the plans on semver going forward? The first here release was 1.0.0 rather than the recommended 0.y.z, however all releases have been marked on GitHub as pre-release and this seems somewhat contradictory.

camelaissani commented 7 years ago

@jdonaldson10 thanks for your contribution You're right about the semver requirement, the first version should had been 0.y.z. However, this version seems to be pretty much stable. I flag it as pre-release because of the unit test failing https://travis-ci.org/camelaissani/rollup-plugin-closure-compiler-js