CGP155: [BUG] Wrong ACL Validation for creating new organizations

camelcasetechsd / certigate

0 stars 0 forks source link

CGP155: [BUG] Wrong ACL Validation for creating new organizations #155

Closed ahmedReda1 closed 8 years ago

ahmedReda1 commented 8 years ago

** wrong cases: TM can create ATC TCA can create ATP

expected cases: TM only create ATP TCA only create ATC

\ Fix ACL seeds for organization and make it based on logged user roles by using ACl method ( validateOrganizationAccessControl ) to make the error message distributive instead of "You don't have access to this , please contact the admin"

ahmedReda1 commented 8 years ago

[x] Role seeds added for new Roles
[x] Fix old role seeds
[x] Fix Acl in creation
[x] Fix attachments fields not appearing in creation
[x] edit instructor role in behat "/organizations/acl/organizationAcl.feature"
[x] Test Cases Passed :
- [x] organizationACL
- [x] organizationType

babanesma commented 8 years ago

this scenario is failing in organizationACL Scenario: List && create && edit organization as instructor

this scenario is failing in organizationType Scenario: test selecting organization type as user