search

camelcasetechsd / skillsbuilder

1 stars 0 forks source link

Footer #248

Closed LamiaSalah closed 5 years ago

LamiaSalah commented 5 years ago

@mohamedMahdyCc Please add Press Room under About Us in the footer section

mohamedMahdyCc commented 5 years ago

@LamiaSalah @ahmedelbougha
Working on this

MuhammedMahdy commented 5 years ago

@LamiaSalah @ahmedelbougha please close this issue , footer menu now dynamic so you can control the sorting

LamiaSalah commented 5 years ago

@MuhammedMahdy please advise how this is done from our end.

mohamedMahdyCc commented 5 years ago

@MuhammedMahdy please advise how this is done from our end.

i think we already discussed this in meeting please close if it's ok.

LamiaSalah commented 5 years ago

@mohamedMahdyCc the issue of linking the footer with the header will not be applied, however, we need to make the footer have the same menu items as the header. Currently there is a difference between both.

mohamedMahdyCc commented 5 years ago

@LamiaSalah yes you can add new menu items with the same link and sorting like the header.

to do this job , you have to select the parent - Footer Menu

mohamedMahdyCc commented 5 years ago

@LamiaSalah @HeshamHassan @HeshamHassan @Ali-Galal

https://docs.google.com/document/d/1uIMzRLOgoOsDfKdLei3kgRUPq52fWAXd5uBfJKbyWIs/edit?usp=sharing

here documentation link on how the new dynamic menu feature working

mohamedMahdyCc commented 5 years ago

@LamiaSalah
please close if done

LamiaSalah commented 5 years ago

@mohamedMahdyCc please give me access to doc. I sent you a request

HeshamHassan commented 5 years ago

Footer is now Dynamic. 👍

@mohamedMahdyCc The items in the footer have some wrong direction. All links redirect to the "Corporate Profile" page whatever I made the "Menu Item Type" Page, Direct URL or Category.

mohamedMahdyCc commented 5 years ago

Footer is now Dynamic.

@mohamedMahdyCc The items in the footer have some wrong direction. All links redirect to the "Corporate Profile" page whatever I made the "Menu Item Type" Page, Direct URL or Category.

@HeshamHassan @Ali-Galal

Apologize for this mistake , fixed now please check and close if it done

HeshamHassan commented 5 years ago

@mohamedMahdyCc The following links are not working:

mohamedMahdyCc commented 5 years ago

@ahmedelbougha @Ali-Galal @HeshamHassan Done! please confirm and close

Ali-Galal commented 5 years ago

@mohamedMahdyCc the footer is ok, but it should be from right to left when it will be in Ar interface.

Ali-Galal commented 5 years ago

reminder

HeshamHassan commented 5 years ago

@mohamedMahdyCc The following links are not working:

  • Trainer's Hub
  • Why Train with SBP?
  • Knowledge Assessments
  • Membership - Individuals I checked their configuration and the link in each menu item is correct... image

Some of the footer links still need to be adjusted:

mohamedMahdyCc commented 5 years ago

@HeshamHassan all of this links Marketing Pro Why Train with SBP? Knowledge Assessments Membership - Individuals this one need to update it's resource link working now , what you mean by adjusted ??

HeshamHassan commented 5 years ago

@mohamedMahdyCc the following are the results which I got when using the selected footer items: Knowledge Assessments: image Membership - Individuals image

Marketing Pro and Why Train with SBP? are working good now.

mohamedMahdyCc commented 5 years ago

@HeshamHassan this pages need to be activated at first

image

HeshamHassan commented 5 years ago

@MuhammedMahdy I made the necessary modifications. They all now working good.