search

camelot-project / frontend

The frontend: The web-facing server software for CAMELOT
BSD 3-Clause "New" or "Revised" License
2 stars 14 forks source link

Added defaults for parameters, if contained in input table #139

Closed ltesti closed 9 years ago

ltesti commented 9 years ago

@keflavich I have added the possibility of reading values of keywords and units from the table (I was annoyed by the need of retyping all the time while testing). I am not an elegant coder. SO please have a look whether you think that what I did makes sense. On my local it works when the table has all or part of the parameters and when it is a simple ascii with no parameters. I have not done extensive testing though...

keflavich commented 9 years ago

Looks good at a glance. I'll test locally before merging. It would be good to get another set of eyes on this too.

ltesti commented 9 years ago

@keflavich I like your point of creating a dictionary. I will change the code to do it that way. I tested using the ipac table ascii format. I am happy to add text and example somewhere in the docs. Here: https://github.com/camelot-project/frontend/wiki/Adding-datasets-through-heroku-website ? Or?

ltesti commented 9 years ago

Did not merged this one, changed following suggestion from Adam.

keflavich commented 9 years ago

@ltesti - you don't have to close the PR; modifications on the same branch are recorded here.