camelot-project / frontend

The frontend: The web-facing server software for CAMELOT
BSD 3-Clause "New" or "Revised" License
2 stars 14 forks source link

Add source link to database entries #61

Closed jmdkastro closed 9 years ago

jmdkastro commented 9 years ago

Early in the week, a main goal was to have an ADS link, DOI link, or email address associated with each data entry, which could possibly be clicked in Eric's plot pop-up.

Given the guaranteed long-term accessibility, we should focus on including ADS links (or a DOI link to the dataset if no paper exists). The entry can be the ADS ID, and the plotting/pop-up code can then complete the URL.

e-koch commented 9 years ago

Relates to #35

scog1234 commented 9 years ago

Question: will this be optional, or do we want to require this by preventing users from uploading data unless they specify a valid ADS ID?

jimdale commented 9 years ago

I think requiring an ADS ID would serve as a form of quality assurance so I'm inclined to require it. Are there circumstances where it would be very beneficial to have unpublished data in the database?

keflavich commented 9 years ago

I think requiring an ADS ID is reasonable, at least for now. Perhaps we could default to 'unpublished', though, to provide some flexibility?

jimdale commented 9 years ago

We could do that - it would mean we have to have another button on the query form in case people want plots with only published data, though.

keflavich commented 9 years ago

That's not a bad idea. We will require a DOI, though - if there is no link to a permanent data source, we should reject.

jimdale commented 9 years ago

Yes, that sounds like the way forward .

jmdkastro commented 9 years ago

So just to confirm: we will not add a "published data only" checkbox on the query form, as we will only be accepting published data. So the upload form should check for a valid ADS ID or DOI (perhaps through two text boxes, checking if at least one has a valid (!) entry).

keflavich commented 9 years ago

@jmdkastro that's not quite what I meant. I was thinking we would accept unpublished data, in the sense of not published in an ADS-identified article, but require that the data set has at minimum a DOI. Perhaps this deserves further discussion via e-mail?

jmdkastro commented 9 years ago

That's exactly what I mean, sorry for my ambiguous phrasing. In a way, ADS or DOI are both "published", but we can nonetheless add an "unpublished" (DOI only) and "published" (ADS and possibly also DOI) checkbox just like for sim/obs and gal/exgal. Of course, this will require an extra column in the database.

keflavich commented 9 years ago

Solved by #84