cameramanben / LUTCalc

Web App for generating 1D and 3D Lookup Tables (LUTs) for video cameras that shoot log gammas.
http://www.lutcalc.net
GNU General Public License v2.0
249 stars 51 forks source link

Bug? Nikon N-Log crushed #22

Closed JoacimSchwartz closed 2 years ago

JoacimSchwartz commented 2 years ago

When creating a LUT using the N-Log option, to match other cameras or even create a rec709, it seems to crush everything extremely, regardless of which settings are used.

Skärmavbild 2022-01-12 kl  01 43 50 No LUT applied

Skärmavbild 2022-01-12 kl  01 43 38 Skärmavbild 2022-01-12 kl  01 44 19 Settings used.

Using other Gamma alternatives does not create replicate the problem. Am I missing some settings or is this a bug?

cameramanben commented 2 years ago

Hi Joacim,

thanks for the heads and it looks to be an easy fix. The Nikon spec uses 10-bit code values in one direction, floating points in the other. LUTCalc is floats all the way and for clarity (oops!) I kept the function as per spec but with some divide by multiply by 1023s.

It seems that two of these divide by 1023s got missed out, but not all, which is why the curve charts and preview look right and the LUTs are going so wrong.

I've made the correction, but I haven't pushed any updates for a while and for some reason I'm having trouble pushing the update to Github. As soon as I've figure out what security setting has changed since the last update I'll upload the change for you to try out.

Thanks,

Ben

JoacimSchwartz commented 2 years ago

Hi Ben,

Thanks for the update, will be looking into it in the future!