feat: integrate LNbits payment processor

michael1011 commented 1 year ago

We added LNbits as payment processor option next to Zebedee

Related Issue

Closes #163

Motivation and Context

We did not want to use Zebedee

How Has This Been Tested?

Works just fine locally. We are going to deploy this on our relay and see if it is stable

Types of changes

[ ] Non-functional change (docs, style, minor refactor)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my code changes.
[ ] All new and existing tests passed.

Semisol commented 1 year ago

I actually was working on this change like a week ago, didn't PR it in until now because I wanted to wait to see if it was working (which it broke actually). My PR is #194

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4151240648

45 of 155 (29.03%) changed or added relevant lines in 15 files are covered.
4 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-1.0%) to 58.03%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/factories/maintenance-worker-factory.ts	0	1	0.0%
src/factories/payments-service-factory.ts	0	1	0.0%
src/factories/post-invoice-controller-factory.ts	0	1	0.0%
src/routes/invoices/index.ts	5	6	83.33%
src/factories/zebedee-callback-controller-factory.ts	0	2	0.0%
src/controllers/callbacks/lnbits-callback-controller.ts	4	7	57.14%
src/controllers/callbacks/zebedee-callback-controller.ts	2	5	40.0%
src/handlers/request-handlers/post-lnbits-callback-request-handler.ts	2	6	33.33%
src/utils/transform.ts	2	6	33.33%
src/routes/callbacks/index.ts	3	10	30.0%
<!--	Total:	45	155	29.03%	-->

Files with Coverage Reduction	New Missed Lines	%
src/factories/maintenance-worker-factory.ts	1	0%
src/factories/payments-processor-factory.ts	3	31.43%
<!--	Total:	4	-->

Totals
Change from base Build 4148256062:	-1.0%
Covered Lines:	1210
Relevant Lines:	2061

💛 - Coveralls

michael1011 commented 1 year ago

@Cameri @antonleviathan are you guys going to merge this PR or #194? If it's #194, I will just close this one and not bother implementing the changes requested in the review

cameri commented 1 year ago

@Cameri @antonleviathan are you guys going to merge this PR or #194? If it's #194, I will just close this one and not bother implementing the changes requested in the review

Looks like #194 is closer to the finish line. Do you mind reviewing it? I'm planning on merging soon.

cameri commented 1 year ago

Closing here in favor of #194

cameri / nostream