Closed im-adithya closed 1 year ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
src/app/maintenance-worker.ts | 0 | 1 | 0.0% | ||
src/payments-processors/payments-procesor.ts | 0 | 1 | 0.0% | ||
src/payments-processors/zebedee-payments-processor.ts | 0 | 3 | 0.0% | ||
src/services/payments-service.ts | 0 | 3 | 0.0% | ||
src/factories/payments-processor-factory.ts | 3 | 10 | 30.0% | ||
src/payments-processors/lnurl-payments-processor.ts | 5 | 22 | 22.73% | ||
<!-- | Total: | 9 | 41 | 21.95% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
src/services/payments-service.ts | 1 | 7.03% | ||
<!-- | Total: | 1 | --> |
Totals | |
---|---|
Change from base Build 4148256062: | -0.6% |
Covered Lines: | 1174 |
Relevant Lines: | 1983 |
@Cameri can you please review this :D
@Cameri can you please review this :D
Thanks for contributing. It's on my todo list.
@im-adithya could you please rebase and fix the conflicts?
Done!
@im-adithya do you have a relay instance running with this where you and I can test this code?
Sorry, I don't :( I just tested it locally
:tada: This PR is included in version 1.23.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
Description
Adds an lnurl processor for payments. We used the LNURL verify spec: https://github.com/lnurl/luds/issues/182
This is made in such a way that any provider can implement, all they have to do is return a verify link in their lnurlp callback.
For example: https://getalby.com/lnurlp/adithya/callback?amount=10000
And a call to the verify URL returns the status:
To support this, we added a
verify_url
field in the database.Related Issue
Motivation and Context
Mitigates the need of adding processors for each and every provider separately.
How Has This Been Tested?
Tested it locally.
Screenshots (if appropriate):
Types of changes
Checklist: