fix: confirm invoice function ambiguous unit variable

cameri / nostream

A Nostr Relay written in TypeScript

MIT License

729 stars 188 forks source link

fix: confirm invoice function ambiguous unit variable #221

Closed cameri closed 1 year ago

cameri commented 1 year ago

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Non-functional change (docs, style, minor refactor)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my code changes.
[ ] All new and existing tests passed.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4225683357

3 of 30 (10.0%) changed or added relevant lines in 4 files are covered.
12 unchanged lines in 5 files lost coverage.
Overall coverage decreased (-0.6%) to 55.9%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/handlers/request-handlers/post-invoice-request-handler.ts	0	1	0.0%
src/controllers/invoices/get-invoice-status-controller.ts	2	7	28.57%
src/app/app.ts	0	8	0.0%
src/factories/payments-processor-factory.ts	1	14	7.14%
<!--	Total:	3	30	10.0%	-->

Files with Coverage Reduction	New Missed Lines	%
src/app/app.ts	1	14.04%
src/factories/payments-processor-factory.ts	1	18.67%
src/handlers/request-handlers/post-invoice-request-handler.ts	1	28.57%
src/controllers/invoices/get-invoice-status-controller.ts	2	12.0%
src/adapters/redis-adapter.ts	7	19.15%
<!--	Total:	12	-->

Totals
Change from base Build 4219844810:	-0.6%
Covered Lines:	1193
Relevant Lines:	2089

💛 - Coveralls

socket-security[bot] commented 1 year ago

Socket Security Pull Request Report

👍 No new dependency issues detected in pull request

Pull request report summary

Issue	Status
Install scripts	✅ 0 issues
Native code	✅ 0 issues
Bin script confusion	✅ 0 issues
Bin script shell injection	✅ 0 issues
Unresolved require	✅ 0 issues
Invalid package.json	✅ 0 issues
HTTP dependency	✅ 0 issues
Git dependency	✅ 0 issues
Potential typo squat	✅ 0 issues
Known Malware	✅ 0 issues
Telemetry	✅ 0 issues
Protestware/Troll package	✅ 0 issues

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@2.4.2

Powered by socket.dev