cameri / nostream

A Nostr Relay written in TypeScript
MIT License
729 stars 188 forks source link

fix: rsv1 error #225

Closed cameri closed 1 year ago

cameri commented 1 year ago

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

sonarcloud[bot] commented 1 year ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.22.6 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

h3ll0ofr1end commented 1 year ago

Hello there, running a relay for several days (v1.22.6) and the RSV1 showed up for the first time.

Schermata 2023-02-28 alle 20 00 37

Attach a copy of the log:

uncaught error: RangeError: Invalid WebSocket frame: RSV1 must be clear
nostream          |     at Receiver.getInfo (/app/node_modules/ws/lib/receiver.js:199:14)
nostream          |     at Receiver.startLoop (/app/node_modules/ws/lib/receiver.js:146:22)
nostream          |     at Receiver._write (/app/node_modules/ws/lib/receiver.js:84:10)
nostream          |     at writeOrBuffer (node:internal/streams/writable:392:12)
nostream          |     at _write (node:internal/streams/writable:333:10)
nostream          |     at Writable.write (node:internal/streams/writable:337:10)
nostream          |     at Socket.socketOnData (/app/node_modules/ws/lib/websocket.js:1274:35)
nostream          |     at Socket.emit (node:events:513:28)
nostream          |     at addChunk (node:internal/streams/readable:324:12)
nostream          |     at readableAddChunk (node:internal/streams/readable:297:9) {
nostream          |   code: 'WS_ERR_UNEXPECTED_RSV_1',
nostream          |   [Symbol(status-code)]: 1002
nostream          | }
pgerstbach commented 1 year ago

Same here, multiple occurrences this night altough being on the latest version!