cameri / nostream

A Nostr Relay written in TypeScript
MIT License
729 stars 188 forks source link

[BUG] #232

Closed taurusites closed 1 year ago

taurusites commented 1 year ago

Multiple subscription Issue To be honest I am not sure whether this is a bug or this is by design, but if I have subscribed twice with the same pubkey while running nostream in a paid configuration I get a NOTICE: subscription rejected

To Reproduce

Steps to reproduce the behavior: Open https://nostr.ownbtc.online and make payment twice with the same pubkey Open https://snort.social and open the dev tools view the console and the notice should show in a short while.

Expected behavior My assumption is that multiple subscriptions should be allowed, and even the NOTICE seems to suggest that.

Screenshots nostreamsubscriptionrejected

System (please complete the following information):

Additional context I have also added the pubkey to the white list section of settings.yml

taurusites commented 1 year ago

subscriptionerror I think this screen cap might be clearer

cameri commented 1 year ago

@taurusites You are using Snort. Looks like your client opens subscriptions over and over and does not close them.

cameri commented 1 year ago

@taurusites Paying a relay or not does not affect subscriptions, it only affects your ability to publish/post to that relay. The issue you see above is a client opening too many subscriptions and then forgetting about them.

taurusites commented 1 year ago

This may possibly be it because it also happens with eden.nostr.land where I paid 2 subscriptions by mistake however the subscription issue also shows up in iris.to. Could it be the same issue there as well ? iriserror

cameri commented 1 year ago

If you paid twice on Eden I can refund you for one. However you are still confused about what a paid relay means: it has nothing to do with subscriptions, paying for it only allows you to publish to it.

cameri commented 1 year ago

Multiple subscriptions are allowed. Please read CONFIGURATION.md and look for limits.client.subscription.maxSubscriptions on information how to change this setting for your own relay.

taurusites commented 1 year ago

Thank you for your patience with me.