cameri / nostream

A Nostr Relay written in TypeScript
MIT License
715 stars 185 forks source link

chore: do not log database password #301

Closed flxxyz closed 1 year ago

flxxyz commented 1 year ago

Description

This change can be displayed as hidden text in the log

Motivation and Context

I don't want sensitive information to be logged, as it could potentially be exposed in the log management of other services (such as docker or k8s).

Types of changes

Checklist:

cameri commented 1 year ago

@flxxyz thanks for contributing! do you mind linting and including unit tests for your changes?

cameri commented 1 year ago

or even better, we could just get rid of the debug statements logging the db config

flxxyz commented 1 year ago

or even better, we could just get rid of the debug statements logging the db config

yeah, sounds good to me

cameri commented 1 year ago

@flxxyz please let me know if you'll push a new commit

flxxyz commented 1 year ago

@flxxyz please let me know if you'll push a new commit

submitted!

cameri commented 1 year ago

@flxxyz changes look good but the linter is complaining. Could you please fix the lint issue and ensure npm run lint exists successfully?

cameri commented 1 year ago

@flxxyz bump