search

cameron / squirt

Speed read the web.
http://www.squirt.io
Apache License 2.0
1.22k stars 206 forks source link

SQUIRT crashing browsers #139

Closed andersonpem closed 10 years ago

andersonpem commented 10 years ago

I see since I updated squirt to the new link I can't read anywhing in Chrome or Firefox. It crashes after allocate more than 2GB of my memory.

cameron commented 10 years ago

What OS are you running?

andersonpem commented 10 years ago

Windows 8.1 Update 1

andersonpem commented 10 years ago

Google Chrome 34.0.1847.116 m Mozilla Firefox 28.0

andersonpem commented 10 years ago

I think I see what's the problem. I'm trying to read a very large document. In the previous version, it was possible without glitches. In this new version, it looks like the script allocate memory in an anormal way and then the browser crash. I'm trying to read the brazilian constitution, a very large text which you can find here: http://www.planalto.gov.br/ccivil_03/constituicao/constituicao.htm

MaddAddaM commented 10 years ago

The bookmarklet used to work nicely on iPads as well, but this update results in a guaranteed crash of the browser now. I'm guessing that this issue is also the cause of this becoming unusable on iPads (latest iOS 7.1).

Let me know if you need any help testing. I love Squirt and I'm happy to test if needed.

cameron commented 10 years ago

@andersonpem haha. i knew this would be a problem but side-stepped the issue in favor of getting something out the door. i'm sorry it's biting you. it's on the TODO list, but is not very high priority, as it's an edge use case. definitely something i'd consider accepting pull requests for as soon as i update the public repo :)

andersonpem commented 10 years ago

Ah, and if you could get back the function which displays how much words I read I'd be glad too. Thanks ;)

cameron commented 10 years ago

You're welcome to poke around in the git repo :)