Αdd simple keyboard shortcuts (#2, #16, #31)

cameron / squirt

Speed read the web.

http://www.squirt.io

Apache License 2.0

1.22k stars 205 forks source link

Αdd simple keyboard shortcuts (#2, #16, #31) #91

Closed FMJansen closed 10 years ago

FMJansen commented 10 years ago

I've added some code to add simple keyboard shortcuts;

_esc_ will close the reader
_space_ will pause the reader
_left arrow_ will rewind 10 seconds

nomicode commented 10 years ago

Right arrow would be good for scrubbing forward.

Also: up and down arrow for increasing and decreasing speed.

nomicode commented 10 years ago

Is bb5ec7a meant to be included in this PR? Seems unrelated.

FMJansen commented 10 years ago

@nslater I agree on the other arrow actions, but I couldn't figure out how to do it as quickly. And no, bb5ec7a shouldn't be included and only was added after pushing it, when this PR was already created. I'll try and give it its own PR.

cameron commented 10 years ago

Hey @FMJansen

Thanks for the contrib, and sorry about the PR getting closed. I've separated the squirt bookmarklet source from the squirt.io source, and crossed a few wires in the process.

Feel free to resubmit your PR against the new files, or I may do some git foo to fix things up this weekend.

Thanks, Cameron

cameron commented 10 years ago

This feature is live. Again, sorry about the PR kerfuffle. I hope it doesn't discourage you from further contributions.