search

cameron314 / concurrentqueue

A fast multi-producer, multi-consumer lock-free concurrent queue for C++11
Other
10k stars 1.69k forks source link

Naming conflict #373

Closed JPewterschmidt closed 10 months ago

JPewterschmidt commented 10 months ago

It's quiet easy to cause a error which the compiler would complain that

error: expected unqualified-id before numeric constant 343 | static const size_t BLOCK_SIZE = 32;

Would you please rename those numeric constant into whatever not like macros? Although I can write #undef BLOCK_SIZE before include the header of ConcurrentQueue to solve the problem.

JPewterschmidt commented 10 months ago

I can submit a PR if you'd like

cameron314 commented 10 months ago

Yes, this is unfortunate. However, as I've explained previously, I cannot change this name without breaking the API.