search

cameron314 / concurrentqueue

A fast multi-producer, multi-consumer lock-free concurrent queue for C++11
Other
10k stars 1.69k forks source link

Consider not making functions in headers static to improve compatibility with C++ modules #402

Open jcelerier opened 2 weeks ago

jcelerier commented 2 weeks ago

If a function is marked static, the header put into the global fragment and a template ends up causing instantiation and thus call of this static function, well, with modules this does not work.

Here's a patch : https://github.com/cameron314/concurrentqueue/commit/324c8187e294a78618c99d19dd7cd43809784333

cameron314 commented 1 week ago

Seems reasonable. Please open a PR with that diff.