search

cameroncondry / cbc-kitten-scientists

Add-on for the wonderful incremental browser game: http://kittensgame.com/web/
MIT License
113 stars 94 forks source link

Remove or make CSS adjustments optional #122

Closed oliversalzburg closed 8 years ago

oliversalzburg commented 8 years ago

I had a look at the Sleeky Theme in 1.1.7.8:

It seems like the Scientists CSS adjustments are conflicting with it. Given the issues that are caused by the CSS adjustments in regards to button labels and the potential conflicts with other themes, I would propose that the CSS adjustments should be removed from the script.

Users who want to keep them, should be able to apply them by other means (Like Stylish, Stylebot, or other userstyle extensions).

I could even see adding a button that makes the adjustments on demand, but I think the automation and presentation features should be separated.

cameroncondry commented 8 years ago

If people or the creator are making better themes for the system, then I am all for removing the css tweaks in kitten scientists. May be fun to offer an option system that will pull in other themes that have been hosted through github. That theme is pretty good.

oliversalzburg commented 8 years ago

Oh god, I just removed the CSS and saw the default theme again. Haven't seen that in a long time. What a disaster!

Maybe styling could be applied conditionally, depending on the value of gamePage.colorScheme.