cameroncondry / cbc-kitten-scientists

Add-on for the wonderful incremental browser game: http://kittensgame.com/web/
MIT License
113 stars 94 forks source link

The big To-Do #123

Open oliversalzburg opened 8 years ago

oliversalzburg commented 8 years ago

I'll try extra-hard to send PRs for all items on this list myself. I just wanted to keep it here :)

cameroncondry commented 8 years ago

Thank you for continuing to update the system. Definitely love that people still find the script useful.

oliversalzburg commented 8 years ago

@cameroncondry I find it very useful and I have a lot of fun working on it as well :) I hope I'll find more time to check more points of the list very soon.

BTW, I tested #120 for quite some time now and the only thing I still feel somewhat odd about are Festivals. I feel like they often start when I switch to the City tab. So I fear that they might not be starting when a different tab is focused. In general though, I feel like that patch is a huge performance improvement.

Ramdat commented 8 years ago

Can you add an option for more log activity filters? Currently it spams the log with finding astronomical events, getting science from the events and making starcharts. It would also be nice to filter out specific automatic crafts, such as furs -> parchment -> compendium.

You removed the added CSS for all themes?

oliversalzburg commented 8 years ago

@Ramdat The CSS is removed only for the Sleek theme. The CSS is still applied for all of the "classical" themes. Some options also apply to the Sleek theme though. Overall, this change just made KS more compatible with the Sleek theme.

The log is a huge pain IMHO and needs a lot more work. I feel like some filters don't actually work and the filters only appear to hide log messages. The messages are still taking up slots in the log. So the hidden entries still push the interesting log entries out of the log.

cameroncondry commented 8 years ago

That is correct about how the log filters work. The script adds a class to the different log items to hide via css. The class could be used instead to simply remove them from the log completely. However, the reason behind hiding them is I originally wanted a way to unhide them, but that is no longer helpful I think since the game has expanded since the log filtering was originally implemented.

oliversalzburg commented 8 years ago

I also optimized one enabled check in https://github.com/oliversalzburg/cbc-kitten-scientists/tree/feature/stages already. I'll create a PR for that when #127 is merged, as that feature relies on some changes in #127.

Ramdat commented 8 years ago

@oliversalzburg The horizontal spacing of the CSS for every theme except Sleek do not work properly for me. It has roughly 400px of blank space on the right side. For reference vanilla has 600px of empty space.

oliversalzburg commented 8 years ago

@Ramdat Huh, weird. Please open a separate issue about this and include some screenshots. I'll look into it.

GronbergInfo commented 8 years ago

Do KS account for IW mode?

cameroncondry commented 8 years ago

Currently there are no specific settings that change functionality for IW mode. You can update the options to work better in IW, like disabling building any type of housing.