search

cameroncondry / cbc-kitten-scientists

Add-on for the wonderful incremental browser game: http://kittensgame.com/web/
MIT License
113 stars 94 forks source link

Auto festival & auto trading no longer functioning #193

Closed metalax closed 7 years ago

metalax commented 7 years ago

Auto festival is no longer functioning following the most recent update. This is also causing KS to hold at that point and not process auto crafting or auto building. If a festival is triggered manually, crafting and building resumes until the festival ends. Disabling auto festival also allows crafting and building to proceed.

Similarly auto trading is not functioning and is blocking auto hunting from occurring. Disabling auto trading allows auto hunting to resume. This is also reliant on having either manually triggered a festival or disabled auto festival, otherwise auto hunting is still blocked.

riannucci commented 7 years ago

The stacktrace for the festival error is

Uncaught TypeError: this.villageManager.tab.festivalBtn.hasResources is not a function
    at Engine.holdFestival (kitten-scientists.user.js:466)
    at Engine.iterate (kitten-scientists.user.js:387)
riannucci commented 7 years ago

I suspect that the incompatibility was introduced here: https://bitbucket.org/bloodrizer/kitten-game/commits/6c260d2c2f06872affa3f6de9d2f7d17e3019262

but it's a pretty huge commit :)

riannucci commented 7 years ago

I suspect that game.villageTab.festivalBtn.model.enabled can be used to determine if the button is currently enabled or not in the current version of kg.

riannucci commented 7 years ago

Yeah it looks like all the various buttons changed from ...Btn.hasResources() to ...Btn.model.enabled booleans. I haven't confirmed that this is afflicting the other ks functions, but reading the code implies that it is. I'll see if I can hack up a fix.

riannucci commented 7 years ago

that said, auto-building doesn't seem to be working either... I suspect someone more familiar than myself will need to go through ks to fully adapt it to the new version.

Darael commented 7 years ago

For auto-trading, the tradeMultiple function on the button is gone, but the functionality is still there - gamePage.diplomacy.tradeMultiple(race,amount) is what's needed for the quick-and-dirty fix, at least.

metalax commented 7 years ago

Looks like the recent updates have fixed these issues, as far as I've been able to test.