search

cameroncondry / cbc-kitten-scientists

Add-on for the wonderful incremental browser game: http://kittensgame.com/web/
MIT License
113 stars 94 forks source link

Trading with Leviathans only occurs when tab is open. #206

Closed afxwinter closed 5 years ago

afxwinter commented 7 years ago

I've noticed that trading is now working again since the last pull however it only occurs when the trade tab is open.

afxwinter commented 7 years ago

Am I the only one having this issue? It's a bit annoying smashing time crystals and then having to keep popping into the trade tab so the trades occur.

catattacktack commented 7 years ago

I'm having the same problem. I traced down the code to line 773: if (!button.model.enabled || !options.auto.trade.items[name].enabled) return;

for whatever reason, button.model.enabled returns false, even when it should be true. Thus KS aborts the trade. I don't think the "!button.model.enabled" is need, so I "fixed" it by just removing that part of the line. Now KS works fine, but I'm not sure that it is safe to remove that. Hopefully someone with more knowledge will look into it.

Wymrite commented 5 years ago

@cameroncondry This issue has been fixed for awhile. There's a lot of open issues/suggestions that had either been fixed or implemented long ago. I don't know too much about github, but I'd be willing to go through and close the outdated ones if there is some way for you to give me that permission.

cameroncondry commented 5 years ago

I like that idea. I think I've given you the proper permissions, just need to accept the invite. 👍