search

cameroncondry / cbc-kitten-scientists

Add-on for the wonderful incremental browser game: http://kittensgame.com/web/
MIT License
113 stars 94 forks source link

Check correct location for active tab id #215

Closed amaranth closed 7 years ago

amaranth commented 7 years ago

As noted in #173 for a while now when the script is enabled buttons in the game stop updating normally. I had previously discovered this was caused by the calls to render the tabs (needed to make sure the buttons exist to click on) but was unable to figure out why. After #213 this started happening to the kitten assignment buttons in the village tab too so I took another look at it. Turns out the problem was pretty simple, the activeTabId variable moved so we were always rendering tabs rather than only when they weren't the active one. This should also give a small performance improvement since we're not doing useless work.

amaranth commented 7 years ago

Hrm, nope, now it doesn't seem to be working at all. Could have sworn this worked when I first tried it...

amaranth commented 7 years ago

Ok, building things at the bonfire works correctly. I just started a new run so I don't have access to the other tabs yet.