cameroncondry / cbc-kitten-scientists

Add-on for the wonderful incremental browser game: http://kittensgame.com/web/
MIT License
113 stars 94 forks source link

Activity Summary shows too many builds #253

Closed DocPhoenix closed 5 years ago

DocPhoenix commented 5 years ago

The activity summary produced by clicking the "Show Activity" link sometimes shows more buildings than were actually built - i.e. "Built: +12 Magnetos" when it only built 8, etc.

Wymrite commented 5 years ago

Would it be possible to provide more details or a screenshot displaying this issue? I've looked over the relevant code a few times and can't find any possible way for this to happen as the number saved for the activity log is the number actually successfully built.

DocPhoenix commented 5 years ago

From what I've seen, it seems to occur when two or more different buildings are available to build at the same time that require the same crafted resource, and there isn't enough of that resource stocked to build them all. I'm specifically seeing this a lot with Sunlifters - if I have enough Eludium to build a Sunlifter OR an Orbital Array, but not both, only the Orbital Array will be built but the logged activity will indicate that both were built.

Wymrite commented 5 years ago

Should be fixed as of the latest version of KS, please let me know if you notice it continue to occur.