cameroncondry / cbc-kitten-scientists

Add-on for the wonderful incremental browser game: http://kittensgame.com/web/
MIT License
113 stars 94 forks source link

Options, Improved Limited Trading, Embassies, and More #262

Closed Wymrite closed 4 years ago

Wymrite commented 4 years ago

@cameroncondry This PR has a couple of major features and a few minor changes. First, KS was starting to get too many menus so I made a new options menu and gave it trigger functionality, then moved all the options that didn't have sub-items into it.

Second, I added a system to keep track of the resources spent and gained hunting and trading so limited trading factors these in, making it self-limiting and replacing the old arbitrary limits on it. This makes it much more capable of taking advantage of any profitable trading loops.

Third, KS can now auto build embassies in the beta branch of KG.

Fourth, automatic space missions and race discovery has been added to the upgrading tab, which has been renamed to unlocking. Upgrading buildings now has some conditions on it to prevent it from doing things like upgrading aqueducts and ruining catnip production.

Besides that, there are some other minor changes that are detailed in the change log that are mostly bug fixes or checks to better handle some features.

Also, found the source of a lot of KS's lag. Turns out the game's logging system was horribly optimized and running a giant unnecessary loop every time a message was added to the log. This has been fixed so whenever the game's website is updated next, pretty much all the lag will disappear.

Wymrite commented 4 years ago

@cameroncondry I don't know if you've tested this at all yet, but I've now swapped the order of trading and hunting in the loop so that hunting goes first, as I was running into some issues with trading reducing catpower below the hunting trigger.

cameroncondry commented 4 years ago

This looks great! I tested it briefly, and trust that you've been testing it thoroughly. Thank you for the additions!