cameroncondry / cbc-kitten-scientists

Add-on for the wonderful incremental browser game: http://kittensgame.com/web/
MIT License
113 stars 94 forks source link

Auto Praise isn't working when it should #272

Open SwiftRosenthal opened 4 years ago

SwiftRosenthal commented 4 years ago

I'm staring at a maxed-out faith pool and nothing is happening. This is my first time playing the game after a couple years, with a new save. Auto-Praise was actually working just fine when I got Theology last week, but it stopped at some point since and I have no idea why. I did temporarily turn off Auto-Praise when I had a faith pool exactly large enough to take one of the earlier religion bonuses (and didn't want to build another temple first) but that shouldn't have had any lasting consequences.

I just now had Tampermonkey check for updates, to be sure. Auto-Praise is currently ticked on.

SwiftRosenthal commented 4 years ago

It works again. All I can think of that might have fixed it was turning off Embassies (...whatever that even does).

scribnermj commented 4 years ago

I'm running into this same problem after moving my game to another machine. I'm using the same browser. I tried a couple of other browsers. I've tried turning off everything and then trying just the praising. Not sure what to do about this.

Just to update this, I've moved from multiple machines and multiple different browsers and still I have no auto praise.

thanks. Great tool!

Caittus commented 4 years ago

Ever since the 'Faith hotfix' that was pushed a few days ago, auto-Praise stopped working for me. I spot-welded that back to the original version and it works again.

scribnermj commented 4 years ago

It has been a few days, I didn't realize there was change as Caittus mentioned. I am not sure how to do the fix that caittus did to solve the issue.

Wymrite commented 4 years ago

Should be fixed as of now, one of the variables got renamed in a certain version and I misinterpreted it as being all versions. This may not fix SwiftRosenthal's problem but I added an additional check to embassies that should hopefully fix that too. Let me know if any of you have further problems after updating.

scribnermj commented 4 years ago

I've completely flushed the browser cache and restarted the game. Sill no faith accumulation. thankyou for looking into this. Appreciated. I'm getting this fault repeatedly.

kitten-scientists.user.js:1153 Uncaught TypeError: game.religion.getApocryphaBonus is not a function

Wymrite commented 4 years ago

The game.religion.getApocryphaBonus call is no longer on line 1153, so KS has not updated for you. Did you try and manually fix it earlier like Caittus? If so, you'll need to manually check for updates through tampermonkey/greasemonkey.

Caittus commented 4 years ago

Can confirm it's working correctly for me again now with the new commit.

scribnermj commented 4 years ago

I'm not sure how to roll back versions or what spot welding is. I use the link on the Main code page to load.

javascript:(function(){var d=document,s=d.createElement('script');s.src='https://cdn.jsdelivr.net/gh/cameroncondry/cbc-kitten-scientists@master/kitten-scientists.user.js';d.body.appendChild(s);})();

After flushing caches and reloading it shows the same version number and the same line number errors as before. All other script changes in the past have come through without my intervention. I'm assuming this one will as well at some point. Thanks for the help everyone.

FuzzyBunnyKG commented 4 years ago

I am having the same issue, along with some time related structures not auto constructing.

scribnermj commented 4 years ago

The auto praise function has resumed and is now working correctly for me. At last check, the error I was seeing in console is also resolved.