search

cameroncondry / cbc-kitten-scientists

Add-on for the wonderful incremental browser game: http://kittensgame.com/web/
MIT License
113 stars 94 forks source link

Script only works for alpha version of game (1.4.2) #279

Open Fringeware opened 4 years ago

Fringeware commented 4 years ago

Works fine in alpha, but beta and main versions give me this error in the console: Uncaught TypeError: game.getHyperbolicEffect is not a function scientists master/kitten-scientists.user.js:1945 scientists master/kitten-scientists.user.js:1821 scientists master/kitten-scientists.user.js:860 scientists master/kitten-scientists.user.js:466

I think they changed the nomenclature recently. From the bitbucket changelog:
Rename “hyperbolic effect” as “limited diminishing return” (as named in the wiki)

AirDur commented 4 years ago

It was fixed : https://github.com/cameroncondry/cbc-kitten-scientists/pull/278 & https://github.com/cameroncondry/cbc-kitten-scientists/blob/master/kitten-scientists.user.js#L1945

But jsdelivr takes time to update the script. You can use this bookmarklet instead to get the last commit (but it'll not be updated if something broke again) : javascript:(function(){var d=document,s=d.createElement('script');s.src='https://cdn.jsdelivr.net/gh/cameroncondry/cbc-kitten-scientists@48136238dac164fb6fbcff3662d00fa46e484f40/kitten-scientists.user.js';d.body.appendChild(s);})();

scribnermj commented 4 years ago

kitten-scientists.user.js:1771 Uncaught TypeError: game.religion.getSolarRevolutionRatio is not a function at CraftManager.getPotentialCatnip (kitten-scientists.user.js:1771) at CraftManager.getValueAvailable (kitten-scientists.user.js:1733) at CraftManager.singleCraftPossible (kitten-scientists.user.js:1580) at Engine.craft (kitten-scientists.user.js:911) at Engine.iterate (kitten-scientists.user.js:468) getPotentialCatnip @ kitten-scientists.user.js:1771 getValueAvailable @ kitten-scientists.user.js:1733 singleCraftPossible @ kitten-scientists.user.js:1580 craft @ kitten-scientists.user.js:911 iterate @ kitten-scientists.user.js:468 setInterval (async) start @ kitten-scientists.user.js:451 (anonymous) @ kitten-scientists.user.js:3279 dispatch @ jQuery.js:2 u @ jQuery.js:2

that light at the end of the tunnel, it looks like a train. With all due respect, is it possible to get a link to a stable release? This seems like alpha software being put out there as the main link. BTW, this second link to an older commit did not work for me.

Riimu commented 4 years ago

If you want to use it on the version on old address (i.e https://bloodrizer.ru/games/kittens/ ), the working commit seems to be 4c737d2ef0a3c0dc8a7f7ef978ca39dcedb1691d, so use the following bookmarklet to get it to work:

javascript:(function(){var d=document,s=d.createElement('script');s.src='https://cdn.jsdelivr.net/gh/cameroncondry/cbc-kitten-scientists@4c737d2ef0a3c0dc8a7f7ef978ca39dcedb1691d/kitten-scientists.user.js';d.body.appendChild(s);})();

On that note, If this script is intended to work only with the new mainline (i.e. http://kittensgame.com/web/ ), perhaps the urls in the project should be updated to reflect that?

scribnermj commented 4 years ago

I had been using the bloodrizer site. I was only slightly aware that there were alpha beta and gamma versions on a different URL. I switched over to the gamma link and it is working correctly. thank you for the assistance.