search

cameroncondry / cbc-kitten-scientists

Add-on for the wonderful incremental browser game: http://kittensgame.com/web/
MIT License
113 stars 94 forks source link

options: have labels show items instead of clicking checkbox #50

Closed jacob-keller closed 9 years ago

jacob-keller commented 9 years ago

I think I am not alone in thinking that clicking the label will show items. Since showing and hiding labels is definitely something we will be doing more and more of as options get more complicated, this patch makes it so that labels will be the same as "items". Possibly we can remove the items button entirely then, but I'm not sold on that yet.

However, it is really frustrating when you meant to make items appear and you instead toggled the checkbox, so modify labels to be divs instead, which will get function of showing items added if we have any.

NOTE: this pull request is equivalent to the other large enhancement with a single additional commit which modifies the toggle options and labels buttons. I didn't think this was as acceptable, so I separated it out. If you pull that, you should be able to pull this one just as easily. However, Be aware this does contain all those commits (as I expect they will be included with out much fanfare given how much feedback I've had already, and how solid the changes are.)

jacob-keller commented 9 years ago

Again, note this includes all the extra commits from my previous pull request. If you don't want this commit, don't pull this series.

If you want this commit, please pull this version instead of the other.

cameroncondry commented 9 years ago

Closing this request as I pulled in the other version with all the changes.