search

cameroncros / OctoPrint-DiscordRemote

Discord plugin for OctoPrint
MIT License
66 stars 34 forks source link

Add support for showing absolute ETA #188

Closed mmirate closed 3 years ago

mmirate commented 3 years ago

i.e. instead of the estimated amount of time remaining in the print, this is the datetime at which the print is estimated to finish.

Also, while I was at it, I put the status-embed's filename field inside backticks, so that filenames containing double underscores don't get mangled by Discord's Markdown interpretation.

mmirate commented 3 years ago 
ERROR: Package 'rsa' requires a different Python: 2.7.17 not in '>=3.5, <4'

<snip>

___________________________________ summary ____________________________________
ERROR:   py27: could not install deps [git+https://github.com/foosel/OctoPrint.git@1.3.12, -rrequirements.txt, -rrequirements-dev.txt]; v = InvocationError('/root/repo/.tox/py27/bin/python -m pip install git+https://github.com/foosel/OctoPrint.git@1.3.12 -rrequirements.txt -rrequirements-dev.txt', 1)
  py37: commands succeeded

FYI, your CI appears to have some pre-existing problems. Though, since Python 2 has been unsupported for quite awhile by Octoprint (let alone by the Python upstream themselves), I think this is trivially fixable by removing Python 2 from this project's testing matrix.

cameroncros commented 3 years ago

Yup, the py27 testing is pretty much pointless, will remove in the future. I will try review this PR soon, thanks for the contribution.

On Fri, 14 May 2021, 8:03 am Milo Mirate, @.***> wrote:

___ summary ____ ERROR: py27: could not install deps @., -rrequirements.txt, -rrequirements-dev.txt]; v = InvocationError('/root/repo/.tox/py27/bin/python -m pip install @. -rrequirements.txt -rrequirements-dev.txt', 1) py37: commands succeeded

FYI, your CI appears to have some pre-existing problems. Though, since Python 2 has been unsupported for awhile by Octoprint (let alone by the Python upstream themselves), I think this is trivially fixable by removing Python 2 from this project's testing matrix.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cameroncros/OctoPrint-DiscordRemote/pull/188#issuecomment-840861008, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAK7FL5ETCW23B7R3ECU6ELTNRECJANCNFSM44ZV7ZVA .

cameroncros commented 3 years ago

Sorry for the delay, but I have now merged this. Thank you for your contribution.

mmirate commented 3 years ago

You're welcome! 😃